Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consecutive sync record CREATE, UPDATE won't be applied on receiving end #6310

Closed
darkdh opened this issue Oct 3, 2019 · 1 comment
Closed

Consecutive sync record CREATE, UPDATE won't be applied on receiving end #6310

darkdh opened this issue Oct 3, 2019 · 1 comment
Assignees
@darkdh
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes feature/sync priority/P2 release-notes/include
Projects
Sync - All platforms
Milestone
0.70.x - Release

Comments

@darkdh
Copy link
Member

@darkdh darkdh commented Oct 3, 2019

This is a regression of brave-syncer(brave/brave-core#2010)
If a device receive a CREATE record and also UPDATE to this record without modifying the bookmark, the UPDATE won't be applied.

STR:

  1. Sync device A and device B
  2. Create folder F1 and bookmark B1 on toolbar of device A
  3. Wait for them to show up on device B
  4. Open chrome://inspect/#extensions on device B and inspect Brave Sync
  5. Move B1 into F1 on device A
  6. When device B receives resolved records, nothing happens on toolbar

Note: This blocks the migration of #5158
@darkdh darkdh added the feature/sync label Oct 3, 2019
@darkdh darkdh self-assigned this Oct 3, 2019
@darkdh darkdh added this to Untriaged backlog in Sync via automation Oct 3, 2019
@darkdh darkdh moved this from Untriaged backlog to In progress in Sync Oct 3, 2019
@darkdh darkdh mentioned this issue Oct 4, 2019
Merged
13 of 32 tasks complete
Sync automation moved this from In progress to Completed Oct 4, 2019
@darkdh darkdh added this to the 0.72.x - Nightly milestone Oct 4, 2019
This was referenced Oct 4, 2019
Merged
Merged
@darkdh darkdh modified the milestones: 0.72.x - Nightly, 0.70.x - Beta Oct 7, 2019
@darkdh darkdh added this to Completed in Sync - All platforms Oct 8, 2019
@darkdh darkdh added the 1.0 label Oct 8, 2019
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 10, 2019 •
edited by GeetaSarvadnya

Verified passed with

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.70.116 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
@kjozwiak kjozwiak mentioned this issue Oct 23, 2019
Closed
@darkdh darkdh removed the 1.0 label Oct 28, 2019
@rebron rebron removed this from Completed in Sync Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes feature/sync priority/P2 release-notes/include
Projects
Sync - All platforms
  
Completed
Milestone
  0.70.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Fix server order out of sync between sender/receiver
5 participants
@bsclifton @darkdh @LaurenWags @btlechowski @GeetaSarvadnya
You can’t perform that action at this time.