Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of Dapp name #6374

Open
srirambv opened this issue Oct 9, 2019 · 0 comments
Open

Inconsistent use of Dapp name #6374

srirambv opened this issue Oct 9, 2019 · 0 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 9, 2019

Description

Inconsistent use of dapp word in extension page

Actual result:

image
image
image

Expected result:

Have consistency in using either Dapps, dApps, Ðapps or dapps. Probably use Ðapps as it has a fancy D 😃

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Component: 1.0.9

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

MM has some inconsistency as well they use dapps under connection and dApps under connect hardware. These are the only two places where they have used the word. All other places are custom text that we have which needs to have consistency.

@srirambv srirambv added this to To do in Crypto Wallets via automation Oct 9, 2019
@bbondy bbondy moved this from Untriaged to Backlog in Crypto Wallets Dec 20, 2019
@bbondy bbondy added the priority/P3 label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.