Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom text isn't translated #6533

Open
srirambv opened this issue Oct 17, 2019 · 0 comments
Open

Custom text isn't translated #6533

srirambv opened this issue Oct 17, 2019 · 0 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 17, 2019

Description

Follow up to #6289. Custom text implemented as part of #6485 isn't translated

Steps to Reproduce

  1. Install component 0.1.17
  2. Set device locale to French
  3. Disclosure message isn't translated
  4. Choose a type to set up: text isn't translated
  5. Back button text isn't translated on create/restore wallet pages
  6. Password info message on create/restore wallet pages aren't translated

Actual result:

Dislosure message
image
Choose a type to set up:
image
Back & password info message on create page
image
Back & password info message on restore page
image

Expected result:

All custom text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux

Ethereum component version 0.1.17

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.