Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sheets not working correct since latest update. v78 #6618

Closed
thommesborg opened this issue Oct 26, 2019 · 11 comments
Closed

Google Sheets not working correct since latest update. v78 #6618

thommesborg opened this issue Oct 26, 2019 · 11 comments

Comments

@thommesborg
Copy link

@thommesborg thommesborg commented Oct 26, 2019

Description

<Since latest update to Version 0.70.121 Chromium: 78.0.3904.70 (Offizieller Build) (64-Bit), Google Sheets won't be displayed correctly. As my English is not so perfect, please have a look at the screenshots below.>

Steps to Reproduce

  1. Open a Google Spreadsheet
  2. See the content in each cell slided out of the cells

Actual result:

Brave doesn't show GSheets correctly.
Bildschirmfoto 2019-10-26 um 09 02 45
Brave result

Expected result:

Brave should show this sheet like Chrome does.
Bildschirmfoto 2019-10-26 um 09 03 44
Chrome result

Reproduces how often:

Everytime

Brave version (brave://version info)

Version 0.70.121 Chromium: 78.0.3904.70 (Offizieller Build) (64-Bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards? not in use
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@rebron
Copy link
Collaborator

@rebron rebron commented Nov 15, 2019

@thommesborg Looks like this works with shields down. Could also probably go into advanced view and allow all device recognition attempts for just Google sheets? Does that work for you?

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Nov 15, 2019

Hi @rebron I confirm with shields down it works as expected.

@rebron rebron moved this from To do to P5 backlog in Web Compatibility Jan 7, 2020
@rebron rebron added the google label Jan 7, 2020
@pes10k
Copy link
Contributor

@pes10k pes10k commented Feb 13, 2020

fwiw, just got an email about this. I dont think we should leave Google Sheets bugs as P5, seems like its gotta be P3, given how popular the service is. WDYT?

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Feb 14, 2020

Hey @thommesborg can you supply a shared link of the Google sheet? Just so we can reproduce the issue, and see what is causing it

@rebron rebron removed the priority/P5 label Feb 14, 2020
@rebron rebron moved this from P5 backlog to P3 backlog in Web Compatibility Feb 14, 2020
@rebron rebron added the priority/P3 label Feb 14, 2020
@thommesborg
Copy link
Author

@thommesborg thommesborg commented Feb 14, 2020

Ho @ryanbr like I've replied here: #6618 (comment) with shields down it works.

There is nothing else in this sheet like text an numbers. You cab easily build your own sheet for testing. This one is shared with the team and is work in process.

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Feb 14, 2020

I couldn't reproduce it here, even with plain text. Just a sample shared sheet would help

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Feb 14, 2020

@ryanbr for the moment I have to rely on a stable service, so I'm on the run with my Chromebook. I can't check the latest version of Brave on this device, because it's a Chromebook.

If you can't repro the issue, maybe it got fixed in between. Will check next time when back home and the MacBook is in reach.

@akshaybhalotia
Copy link

@akshaybhalotia akshaybhalotia commented May 14, 2020

I came here looking exactly for this. Somehow this is a tricky one. I'll keep posting my findings here, since G Sheet is an essential part of my workflow.

  1. The scrambled view appears when opening a Google Sheet (author could be yourself or someone else but given sheet must not have been created in this browser), but not when creating a new one, even if you copy paste the same data. Probably why @ryanbr wasn't able to repro.

  2. Works fine with shields up except fingerprinting. The number of blocks used to be 3 before, reduced to 1.
    image

  3. Once allowing fingerprint and then blocking it again seems to resolve the issue permanently. Number of blocked content remains at 1 instead of going back to 3. Even opening new sheets which have previously never been opened in this browser seem to work correctly. Looks like some cookie being set in the fingerprinting process that "enables" the correct render.

@akshaybhalotia
Copy link

@akshaybhalotia akshaybhalotia commented May 14, 2020

Could not attempt trying in private mode before disabling the fingerprint experiment. Cannot reproduce after, so not sure if this is consistent.

@pes10k
Copy link
Contributor

@pes10k pes10k commented May 15, 2020

I can't reproduce either. I expect our new fingeprinting protections will solve, and that this is related to us blocking some font-measurement APIs in the previous fingerprinting protections system.

If anyone is still seeing, could you share a link to a google doc thats showing the problem (even if its in read-only mode) and I can figure out exactly whats going on with this and fingerprinting protections? Otherwise, if no one is still seeing, lets close the issue

@thommesborg
Copy link
Author

@thommesborg thommesborg commented May 15, 2020

@pes10k hi, so for me the issue is solved. If I go to the sheet I had trouble with at the time I started this bug, it looks well now.

Bildschirmfoto 2020-05-15 um 06 13 16

Cheers,
Thomas

Web Compatibility automation moved this from P3 backlog to Done May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.