Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for downloading adblock / tracking protection data files #676

Open
bsclifton opened this issue Aug 2, 2018 · 0 comments
Open
Labels

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 2, 2018

Carried over from brave/browser-laptop#125

The tests should:

  • Check for proper handling for 404 if adblock data file isn't uploaded correctly
  • Check for proper handling if adblock server is offline
  • Check for proper handling if time elapsed since last check is > 1 day
  • Check if there is proper handling when reading cached storage from disk
  • Check if there is proper handling when a 2nd window is open
  • Check for proper handling when etags match
  • Check for proper handling when etags do not match
@bsclifton bsclifton added the tests label Aug 2, 2018
@bsclifton bsclifton added this to the Backlog milestone Aug 2, 2018
@bsclifton bsclifton changed the title Add tests for downloading adblock / tracking protection data files Add automated tests for downloading adblock / tracking protection data files Aug 2, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.