Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW buttons should use Brave brand style #6770

Closed
LaurenWags opened this issue Nov 5, 2019 · 1 comment
Closed

CW buttons should use Brave brand style #6770

LaurenWags opened this issue Nov 5, 2019 · 1 comment
Labels
closed/wontfix design A design change, especially one which needs input from the design team feature/ethereum-remote-client priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 5, 2019

Description

Similar to #6398

Crypto Wallet buttons should use Brave brand styling.

Steps to Reproduce

  1. Navigate to Crypto Wallets
  2. Enable and confirm buttons use Brave brand style

Actual result:

Crypto wallet buttons do not use Brave brand style (some screenshots of all buttons can be seen here: #6398 (comment) )

Expected result:

Crypto wallet buttons should use Brave brand style

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support labels Nov 5, 2019
@LaurenWags LaurenWags added this to To do in Wallet via automation Nov 5, 2019
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Dec 20, 2019
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 20, 2019
@bbondy
Copy link
Member

bbondy commented Jul 21, 2021

This won't be worked on since we are deprecating the extension in favor of the new Brave Wallet. Closing.

@bbondy bbondy closed this as completed Jul 21, 2021
Wallet automation moved this from Crypto Wallets Extension Backlog to Closed Jul 21, 2021
@bbondy bbondy removed this from Closed in Wallet Jul 21, 2021
@bbondy bbondy added this to Untriaged in Ethereum Remote Client Extension via automation Jul 21, 2021
@bbondy bbondy moved this from Untriaged to Closed in Ethereum Remote Client Extension Jul 21, 2021
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix design A design change, especially one which needs input from the design team feature/ethereum-remote-client priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
Development

No branches or pull requests

3 participants