Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resend records in callback of send-sync-records #6834

Closed
darkdh opened this issue Nov 8, 2019 · 0 comments
Closed

Remove resend records in callback of send-sync-records #6834

darkdh opened this issue Nov 8, 2019 · 0 comments
Assignees
@darkdh
Labels
QA/No feature/sync release-notes/exclude
Projects
Sync - All platforms
Milestone
1.3.x - Release

Comments

@darkdh
Copy link
Member

@darkdh darkdh commented Nov 8, 2019

Implement the callback added in the PR resolves brave/sync#356

So that we don't have some resend records queued up forever because we never see those on SQS
@darkdh darkdh added the feature/sync label Nov 8, 2019
@darkdh darkdh self-assigned this Nov 8, 2019
@darkdh darkdh added this to Untriaged backlog in Sync - All platforms via automation Nov 8, 2019
@darkdh darkdh moved this from Untriaged backlog to In Progress in Sync - All platforms Nov 8, 2019
@darkdh darkdh mentioned this issue Nov 8, 2019
Merged
7 of 32 tasks complete
@darkdh darkdh added the QA/No label Nov 8, 2019
Sync - All platforms automation moved this from In Progress to Completed Nov 9, 2019
@darkdh darkdh added this to the 0.74.x - Nightly milestone Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
QA/No feature/sync release-notes/exclude
Projects
Sync - All platforms
  
Completed
Milestone
  1.3.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Implment OnRecordsSent and delete resend_records within it
2 participants
@darkdh @LaurenWags
You can’t perform that action at this time.