Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate HTTPSEverywhere #7

Closed
bbondy opened this issue Nov 10, 2017 · 2 comments
Closed

Integrate HTTPSEverywhere #7

bbondy opened this issue Nov 10, 2017 · 2 comments
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 10, 2017 •
edited by srirambv

Test Plan:

Visit http://https-everywhere.badssl.com/ in a new tab
Should automatically upgrade to https://https-everywhere.badssl.com/
@bbondy bbondy added this to the Milestone 1: Open Source milestone Dec 5, 2017
@bbondy
Copy link
Member Author

@bbondy bbondy commented Dec 19, 2017

This landed so closing.
@bbondy bbondy closed this Dec 19, 2017
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bridiver
Merge pull request #7 from brave/windows_build
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a86e13a 
Fix create_string_rc build error on Windows
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 20, 2018 •
edited by kjozwiak

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bbondy @kjozwiak @srirambv @btlechowski
You can’t perform that action at this time.