Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider using upstream https-everywhere chrome extension instead of our custom one #700

Closed
diracdeltas opened this issue Aug 7, 2018 · 3 comments
Closed

consider using upstream https-everywhere chrome extension instead of our custom one #700

diracdeltas opened this issue Aug 7, 2018 · 3 comments
Labels
feature/https-everywhere priority/P4 sec-low security

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Aug 7, 2018

benefits: rulesets stay up-to-date without us needing to manually update
downsides: may be less performant

https://chrome.google.com/webstore/detail/https-everywhere/gcbommkclmclpchllfjekcdonpmejbdp
@bbondy bbondy added this to the Backlog milestone Aug 16, 2018
@diracdeltas diracdeltas mentioned this issue Sep 24, 2018
Open
@diracdeltas diracdeltas changed the title use upstream https-everywhere chrome extension instead of our custom one consider using upstream https-everywhere chrome extension instead of our custom one Oct 23, 2018
@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented Oct 23, 2018

this is blocked on doing some perf tests to see if there is a meaningful difference between using the extension vs native
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@fmarier
Copy link
Member

@fmarier fmarier commented Jul 18, 2019

Apparently the performance of the extension has improved thanks to a new Rust/WebAssembly library (see #5280).
@tomlowenthal
Copy link
Member

@tomlowenthal tomlowenthal commented Jul 30, 2019

Closed in favor of #5280.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/https-everywhere priority/P4 sec-low security
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@fmarier @diracdeltas @tomlowenthal @bbondy @rebron
You can’t perform that action at this time.