Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip banner goes blank when publisher status is being refreshed #7009

Open
srirambv opened this issue Nov 19, 2019 · 1 comment
Open

Tip banner goes blank when publisher status is being refreshed #7009

srirambv opened this issue Nov 19, 2019 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Nov 19, 2019

Description

Tip banner goes blank when publisher status is being refreshed

Steps to Reproduce

  1. Visit any unverified site and open rewards panel
  2. Click on refresh
  3. Click on Send tip or Set monthly tip
  4. Banner opens but is blank. banner contents only shows up after the pub status refresh is completed

Actual result:

tip_banner

Expected result:

Tips banner should either have a message saying Updating publishers list or just show the tip banner and continue the update in background

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@srirambv srirambv added this to New Issues in Rewards via automation Nov 19, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Icebox in Rewards Nov 19, 2019
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Apr 10, 2020

@jenn-rhim @alexwykoff what would we like to display in this case, where publisher is not available because of reason X?

@NejcZdovc NejcZdovc moved this from Icebox to Decision (@mandar-brave) in Rewards Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Decision (@mandar-brave)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.