Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAds region on iOS is unsupported if users Calendar is set to a non-default option #7029
Comments
|
@kylehickinson Thinking about this it would be better if we pass an ISO code to the library, which can be concatenated using |
|
@kylehickinson If we use |
|
Preferred Languages won't work here either, as it returns the incorrect format. Example:
|
This was referenced Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In iOS/macOS we use
NSLocaleto determine the users current locale and feed this into the ads library. If an iOS user sets a non-default calendar for their region (For example switching fromGregoriantoJapanese) the identifier reported byNSLocaleends up looking like thisen_US@calendar=japanesewhich then is not parsed correctly by bat-native-ads since it is looking foren_USspecifically.Currently unknown whether or not this issue happens in macOS as well (Chromium may not use
NSLocale.identifierdirectly as iOS does)