Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C79 bump breaks debug build on Linux #7055

Open
mkarolin opened this issue Nov 21, 2019 · 5 comments
Open

C79 bump breaks debug build on Linux #7055

mkarolin opened this issue Nov 21, 2019 · 5 comments

Comments

@mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Nov 21, 2019

This maybe different for various flavors of Linux, I am building on Mint Cinnamon 19.2

When building debug build on Linux, the build itself succeeds, but the executable cannot run.
The following error is shown:

brave-browser/src/out/Debug/brave: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by brave-browser/src/out/Debug/brave)

This is due to the following Chromium change:
https://chromium.googlesource.com/chromium/src/+/695245c
(also see https://bugs.chromium.org/p/chromium/issues/detail?id=1012850)
which rolls sysroots from GLIBC_2.27 (which is what my OS has) to GLIBC_2.29.

See src/build/linux/debian_sid_amd64-sysroot libraries.

  • Reverting this commit:
    src> git revert 695245cf8ad88b73cac7ccd4f5bcda88fc16bf83
  • Then, running
    src> ./build/linux/sysroot_scripts/install-sysroot.py --arch=amd64
  • Then, rebuilding - fixes the error (the libraries in the src/build/linux/debian_sid_amd64-sysroot are rolled back to 2.27).

cc: @iefremov @simonhong @bsclifton

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Dec 14, 2019

it really shouldn't matter what your OS has because it bundles everything it needs afaik other than the things installed by install-build-deps.sh, but I don't see any changes to install-build-deps.sh in that commit? Maybe they happened somewhere else?

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Dec 15, 2019

same think happened to me on ubuntu

@bsclifton bsclifton added this to the 1.4.x - Nightly milestone Dec 18, 2019
@mkarolin mkarolin changed the title C79 bump break debug build on Linux C79 bump breaks debug build on Linux Dec 18, 2019
@mkarolin
Copy link
Contributor Author

@mkarolin mkarolin commented Dec 18, 2019

Reopening because this issue refers specifically to debug builds, whereas brave/brave-core#4255 fixes the issue that appeared in release builds. The issue with debug builds was present before cosmetic filtering changes.

@mkarolin mkarolin reopened this Dec 18, 2019
@mkarolin
Copy link
Contributor Author

@mkarolin mkarolin commented Dec 18, 2019

It is quite likely, though, that the reason the debug build breaks is the same - rust linking with GLIBC in Chromium's sysroot.

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 16, 2020

Re-opening as I believe this was closed on accident

@bsclifton bsclifton reopened this Jan 16, 2020
@bsclifton bsclifton removed this from the 1.4.x - Release milestone Feb 20, 2020
@bsclifton bsclifton added this to Needs triage in Chromium Rebasing via automation Feb 20, 2020
@AndriusA AndriusA mentioned this issue Apr 28, 2020
4 of 32 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Chromium Rebasing
  
Needs triage
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.