Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check foreign keys #7082

Closed
NejcZdovc opened this issue Nov 25, 2019 · 1 comment
Closed

Check foreign keys #7082

NejcZdovc opened this issue Nov 25, 2019 · 1 comment
Labels
closed/not-actionable feature/rewards

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Nov 25, 2019

We should check our foreign keys and if they are not indexes we should create them as indexes.

This is based on https://www.sqlite.org/foreignkeys.html#fk_indexes :

So, in most real systems, an index should be created on the child key columns of each foreign key constraint. The child key index does not have to be (and usually will not be) a UNIQUE index.
@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Nov 25, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Icebox in Rewards Nov 28, 2019
@NejcZdovc
Copy link
Member Author

@NejcZdovc NejcZdovc commented Mar 20, 2020

closing as we remove foreign keys completely from our DB
@NejcZdovc NejcZdovc closed this Mar 20, 2020
@NejcZdovc NejcZdovc removed this from Icebox in Rewards Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/not-actionable feature/rewards
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@NejcZdovc
You can’t perform that action at this time.