Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcompat reporter should not be shown for internal pages #7187

Open
srirambv opened this issue Dec 3, 2019 · 2 comments
Open

Webcompat reporter should not be shown for internal pages #7187

srirambv opened this issue Dec 3, 2019 · 2 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 3, 2019

Description

Webcompat reporter should not be shown for internal pages

Steps to Reproduce

  1. Install nightly
  2. Open brave://settings
  3. Menu -> Report broken site brings up compat reporter

Actual result:

image

Expected result:

Option should only work on sites and not on internal pages as shields is disabled on internal pages

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.3.44 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 6, 2019

webcompat reporter should probably only be shown for http(s) pages?

@rebron
Copy link
Collaborator

@rebron rebron commented Jan 24, 2020

cc: @antonok-edm Can you take a look?

@rebron rebron moved this from Untriaged backlog to P4 backlog in Front End Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.