Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping banner isn't showing verified pubs image #7189

Open
GeetaSarvadnya opened this issue Dec 3, 2019 · 6 comments
Open

Tipping banner isn't showing verified pubs image #7189

GeetaSarvadnya opened this issue Dec 3, 2019 · 6 comments

Comments

@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Dec 3, 2019

Description

Tipping banner isn't showing verified pubs image

Steps to Reproduce

  1. Clean profile 1.3.50 - launch brave with staging flag
  2. Enable rewards
  3. Send a one time tip to a verified Reddit pub https://www.reddit.com/user/alex_the_brave/
  4. Tipping banner isn't showing verified pubs image

Actual result:

Tipping banner isn't showing verified pubs image
image

Expected result:

Tipping banner should show verified pubs image
image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 3, 2019

Looks like the title on the banner is showing incorrectly as well. It shouldn't say reddit#channel:11ncas it should say alex_the_brave on Reddit as it does in the second image.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Dec 4, 2019

I can't reproduce this one on the latest master.

@NejcZdovc NejcZdovc moved this from New Issues to Need investigation/Suggestions in Rewards Dec 4, 2019
@GeetaSarvadnya
Copy link
Collaborator Author

@GeetaSarvadnya GeetaSarvadnya commented Dec 4, 2019

@NejcZdovc The issue is reproducible in the latest nightly build version 1.4.1.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Dec 4, 2019

tried on 1.4.1, still can't reproduce will ping you on slack

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Dec 4, 2019

I can reproduce on Windows, so it's windows specific

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Apr 10, 2020

@GeetaSarvadnya still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Need investigation/info
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.