Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Dev has "Chromium" branding on "Manage People" menu #7234

Closed
Brave-Matt opened this issue Dec 6, 2019 · 2 comments
Closed

Brave Dev has "Chromium" branding on "Manage People" menu #7234

Brave-Matt opened this issue Dec 6, 2019 · 2 comments
Labels
branding feature/profile-manager feature/user-interface needs-investigation
Milestone
Closed / Dupe / I...

Comments

@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Dec 6, 2019

Description

In Dev build:

Brave | 1.3.56 Chromium: 79.0.3945.56 (Official Build) dev (64-bit)
Revision | 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS | macOS Version 10.15.1 (Build 19B88)

Manage People menu looks like this:
image

Steps to Reproduce

  1. Open Profile Manager screen in Brave Dev

Actual result:

Shows "Chromium"

Expected result:

Should show "Brave"

Reproduces how often:

Always
@bsclifton bsclifton added the branding label Dec 6, 2019
@rebron rebron added this to P1 & P2 backlog in Front End Dec 10, 2019
@rebron rebron added the priority/P2 label Dec 10, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Jan 6, 2020

Screen Shot 2020-01-06 at 3 06 33 PM

@Brave-Matt Can you try again in Beta? see screenshot above.
@rebron rebron moved this from P1 & P2 backlog to Untriaged backlog in Front End Jan 7, 2020
@rebron
Copy link
Collaborator

@rebron rebron commented Jan 7, 2020

Closing. Looks like this issue isn't happening any longer.
@rebron rebron closed this Jan 7, 2020
@rebron rebron removed this from Untriaged backlog in Front End Jan 9, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branding feature/profile-manager feature/user-interface needs-investigation
Projects
None yet
Milestone
  Closed / Dupe / I...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@petemill @bbondy @Brave-Matt @bsclifton @rebron
You can’t perform that action at this time.