Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info icon on P3A info bar should be updated #7257

Open
LaurenWags opened this issue Dec 6, 2019 · 1 comment
Open

info icon on P3A info bar should be updated #7257

LaurenWags opened this issue Dec 6, 2019 · 1 comment

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 6, 2019

Description

Found while testing #6285

The info "i" icon on the P3A notification bar is blue. This should be updated per discussion with @karenkliu

Steps to Reproduce

  1. Have a profile on 1.0.1
  2. Update to 1.1.x
  3. See P3A info bar

Actual result:

Screen Shot 2019-12-06 at 4 02 51 PM

Expected result:

info icon should be updated to be Brave style:
icon-info.svg.zip

Reproduces how often:

easily

Brave version (brave://version info)

1.1.18

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @bsclifton @rebron @brave/legacy_qa

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Dec 9, 2019

Removing this from the 1.1.x milestone after discussing it with @bsclifton @rebron. This seems like a minor problem that can be fixed in the next version if needed. We don't have time to get this fixed and into a new RC as we're releasing tomorrow. Issue should be triaged to determine where it should land.

@kjozwiak kjozwiak removed this from the 1.1.x - Release milestone Dec 9, 2019
@rebron rebron added this to P3 backlog in Front End Dec 10, 2019
@rebron rebron moved this from P3 backlog to P4 backlog in Front End Feb 7, 2020
@rebron rebron added the priority/P4 label Feb 7, 2020
@bsclifton bsclifton added this to ready to implement in P3A Feb 24, 2020
@bsclifton bsclifton moved this from ready to implement to implemented, needs rework in P3A Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P4 backlog
P3A
  
implemented, needs rework
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.