Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework `network-audit` into a browser test suite #7281

Open
bsclifton opened this issue Dec 9, 2019 · 0 comments
Open

Rework `network-audit` into a browser test suite #7281

bsclifton opened this issue Dec 9, 2019 · 0 comments

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 9, 2019

Description

See #7207 for history

Until #7182, all platforms were killing the browser during network-audit using SIGKILL. This doesn't let the browser finish writing the logs and requires a manual work-around to make the logs parseable. The integrity of those logs is then questionable

While solving, @bridiver mentioned creating a new test suite, something like npm run test brave_network_audit that would accomplish the same thing as this test. That could then be expanded to run other scenarios (which also accumulate in that log)

from @bridiver

I think the best fix for this is to turn it into a browser test that runs with a separate command. I pointed @bsclifton to LogNetLogTest which tests the basic functionality so we can use that as a template and add our checks. I think it's also better because we can do navigation, etc... that might trigger other requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.