Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave on macOS Catalina won’t get any location #7309

Open
thommesborg opened this issue Dec 10, 2019 · 11 comments
Open

Brave on macOS Catalina won’t get any location #7309

thommesborg opened this issue Dec 10, 2019 · 11 comments

Comments

@thommesborg
Copy link

@thommesborg thommesborg commented Dec 10, 2019

I’ve created issue #5795 before to show that Brave on macOS gets wrong location information. As that issue got renamed and is now used to discuss wrong localization of Brave across all possible OS‘, I was advised to create a new issue for:

Brave on macOS Catalina won’t get any location - starting with macOS Catalina 10.15.1

Steps to Reproduce

  1. Make sure you’re on macOS Catalina 10.15.1
  2. visit Google Maps or similar, like Open Street Maps
  3. if not happened before, grant location-access if you see a browser prompt
  4. realize that Brave, like Chrome, won’t fetch any location.

Expected result:

See your location marked on the map

Reproduces how often:

Always

Brave version (brave://version info)

I think it was 1.0.1 — at the moment I’m writing this using my iPad — but I’m sure I’m always checking with the latest stable browser release.

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No (not in use)
  • Is the issue reproducible on the latest version of Chrome? Yes!
@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 11, 2019

Additional information:

I’ve checked the behavior with today’s update to version 1.1.20 (Chromium 79) and the issue is still there.

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 14, 2019

Addition:

Today I've checked with
Brave 1.1.21
Chromium: 79.0.3945.79 (Official Build) (64-bit)

Sadly the issue persists.

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 16, 2019

Updated to macOS Catalina 10.15.2 and the issue persists.

@fharper
Copy link

@fharper fharper commented Dec 16, 2019

My guess is that it's because of the new privacy system in Catalina. Brave need to ask location permission at the system level, and the user need to authorize it so it will be added in the "Security & Privacy > Privacy > Location Services" apps list.

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 17, 2019

Hi @fharper good guess, but we had no entry in the system settings before Catalina. After granting permission for location since Catalina Brave also don't show up in the system settings.

This could have changed with Catalina. But who to blame here? Brave or Apple? I posted to the Apple forums as well but without any help there.

@fharper
Copy link

@fharper fharper commented Dec 17, 2019

I think Apple reinforces the security process a lot. When I installed the OS, I got a lot of popups asking me for many permission for all apps that were doing fine before. Anyway, it's just an idea as I didn't look at the code at all.

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 17, 2019

I do believe Catalina will ask for permissions, but as weird as this sounds, it won't ask for Location Services. We use a Mozilla endpoint that is used for Firefox Nightly, so system location services are never queried

For what it's worth, I did have to add Brave under Security & Privacy => Accessibility under Allow the apps below to control your computer.

@fharper
Copy link

@fharper fharper commented Dec 17, 2019

@bsclifton unfortunately, adding Brace in accessibility didn't solve my issue.

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 17, 2019

@bsclifton Catalina isn't the one who ask for permission, it's Brave or Chrome that ask for permission. Both don't show up under Security > Privacy > Location Services and never did before Catalina.

@thommesborg
Copy link
Author

@thommesborg thommesborg commented Dec 19, 2019

For your interest: Chrome is having the same issue so I reported that bug on the chromium site.
The bug is assigned and the staff tries to fix it.

https://bugs.chromium.org/p/chromium/issues/detail?id=1035290

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 30, 2019

@thommesborg thanks for reporting! Looks like they're making progress 😄 (able to reproduce)

@rebron rebron added this to Untriaged Backlog in General Feb 11, 2020
@bsclifton bsclifton added this to Waiting for upstream to fix in Chromium Rebasing Feb 18, 2020
@rebron rebron removed this from Untriaged Backlog in General Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Chromium Rebasing
  
Waiting for upstream to fix
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.