Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync polls S3 twice a minute when there are no activity for 24 hours #7327
Comments
This was referenced Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If Brave desktop browser has sync enabled, but there were no changes on synced objects, then data gets queried from AWS S3 storage and not from SQS.
This happens because the last bookmark operation time is may be older than 24 hours, and we pass the last record timestampt, so (currentTime - startAtToCheck) > 24 hours at https://github.com/brave/sync/blob/staging/client/requestUtil.js#L273
Steps to Reproduce
Option I, quick
Sources tab, clickPretty printbuttonif (this.shouldListObject(startAt, category) || opts.compaction) {if (this.shouldListObject(startAtline and set the breakpoint on thereActual result:
const s3ObjectsPromise = s3Helper.listObjects(this.s3, options, !!maxRecords);Expected result:
Option II, needs > 24h to see
Option I...................
6 Code should go into
ifblock, as we want to fetch from S3Reproduces how often:
Easily
Brave version (brave://version info)
Version/Channel Information:
On any channel.