Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ability to import "Cookies" when importing into Brave from IE #7405

Open
kjozwiak opened this issue Dec 16, 2019 · 1 comment
Open

remove ability to import "Cookies" when importing into Brave from IE #7405

kjozwiak opened this issue Dec 16, 2019 · 1 comment

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Dec 16, 2019

Description

We need to remove the ability to import Cookies from IE when importing data into Brave. This is a follow up to #7044 which removed Cookies import from both Firefox and Chrome.

Steps to Reproduce

Test Case #1

  1. visit brave://welcome
  2. go into the Import bookmarks and settings section of the onboarding experience
  3. ensure that cookies are not being imported when selecting Microsoft Internet Explorer

Test Case #2

  1. visit brave://settings/importData
  2. ensure that Cookies isn't being listed under Select items to import:

Actual result:

cookiesIE

Expected result:

Cookies should be removed from the list of available options for IE.

Reproduces how often:

100% reproducible when using the STR mentioned above.

Brave version (brave://version info)

Brave 1.1.21 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Windows 10 OS Version 1909 (Build 18363.535)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bsclifton @rebron @brave/legacy_qa

@kjozwiak
Copy link
Member Author

@kjozwiak kjozwiak commented Dec 16, 2019

Waiting on a decision re: if we need to include this in the HF. We'll move this out into 1.2.x if we only need to worry about Firefox and Chrome for this particular HF/release.

@kjozwiak kjozwiak removed this from the 1.1.x - Release Hotfix 2 milestone Dec 16, 2019
@rebron rebron added this to Untriaged Backlog in General Dec 17, 2019
@rebron rebron added the priority/P2 label Dec 17, 2019
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Dec 17, 2019
@rebron rebron moved this from P4 Backlog to P1 & P2 Backlog in General Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
P1 & P2 Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.