Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 79.0.3945.79 to Chromium 79.0.3945.88 #7435

Closed
mkarolin opened this issue Dec 17, 2019 · 9 comments · Fixed by #7436 or brave/brave-core#4244
Closed

Upgrade from Chromium 79.0.3945.79 to Chromium 79.0.3945.88 #7435

mkarolin opened this issue Dec 17, 2019 · 9 comments · Fixed by #7436 or brave/brave-core#4244

Comments

@mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Dec 17, 2019

QA tests:

Check branding items
Check for version bump

@LaurenWags

This comment has been minimized.

Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 18, 2019

Verified passed with

Brave 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-12-18 at 5 20 55 PM

Verification passed on

Brave 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

image

Verification PASSED on Win 10 x64 using the following build:

Brave 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1909 (Build 18363.535)

Annotation 2019-12-18 215304

@darkdaysdawn

This comment has been minimized.

Copy link

@darkdaysdawn darkdaysdawn commented Jan 2, 2020

FYI: Chromium 79.0.3945.88 appears to have introduced a bug that affects users running Linux (Ubuntu 18.04 flavours) inside VirtualBox.

The symptom is that keyboard and mouse input inside the current tab freeze. The only way to unfreeze is to select a different tab with the mouse, and then return to the previous tab. Freezing occurs every few seconds to minute or so, resulting in a painful experience.

This issue is now present in both Brave and Chrome, but not in the previous version of Chromium (79.0.3945.79) which Brave was using prior to this commit/merge.

@mkarolin

This comment has been minimized.

Copy link
Contributor Author

@mkarolin mkarolin commented Jan 3, 2020

@darkdaysdawn

This comment has been minimized.

Copy link

@darkdaysdawn darkdaysdawn commented Jan 3, 2020

@mkarolin Yes, that's the issue. It's been submitted to Google Chrome's forums too.

The issue exists in Brave now too, since it's based on Chromium.

Unfortunately, rolling back Brave to 1.1.20 doesn't completely fix the issue. Webpages still freeze.

Chromium version 79.0.3945.79 does not have this **issue.

@darkdaysdawn

This comment has been minimized.

Copy link

@darkdaysdawn darkdaysdawn commented Jan 3, 2020

Rolling back Brave to 1.0.1 fixes the problem.

(Maybe had to go back that far to get rid of libs and artifacts that came with later versions and were still lingering after the downgrade? Not sure. Works without freezing now though)

@bsclifton

This comment has been minimized.

Copy link
Member

@bsclifton bsclifton commented Jan 3, 2020

@darkdaysdawn thanks for raising this (and confirming that is the issue tracking it) 😄

@csaroff

This comment has been minimized.

Copy link

@csaroff csaroff commented Jan 3, 2020

I think this broke my jupyter installation for some reason. Seems to work in incognito mode just fine, but when I have the brave shield up, it's never able to connect to the kernel.

@ryanbr

This comment has been minimized.

Copy link
Collaborator

@ryanbr ryanbr commented Jan 3, 2020

@csaroff Interesting, we had a report from a similar issue on Jupyter on #7559

@darkdaysdawn

This comment has been minimized.

Copy link

@darkdaysdawn darkdaysdawn commented Jan 3, 2020

@darkdaysdawn thanks for raising this (and confirming that is the issue tracking it)

I really dig Brave. Happy to help!

If there's any more info I can provide, I will. Just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.