Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building apks with chrome_modern_public_apk option #7491

Open
mthomos opened this issue Sep 25, 2019 · 4 comments
Open

Consider building apks with chrome_modern_public_apk option #7491

mthomos opened this issue Sep 25, 2019 · 4 comments

Comments

@mthomos
Copy link

@mthomos mthomos commented Sep 25, 2019

I saw that you build APKs using both monochrome and modern options. Should you consider using only modern option especially for 64bit versions to reduce APK size.

https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_instructions.md#Multiple-Chrome-APK-Targets

@mthomos
Copy link
Author

@mthomos mthomos commented Oct 11, 2019

Can anyone take a look at this ?

@mthomos
Copy link
Author

@mthomos mthomos commented Oct 13, 2019

With current implementation 64bit binaries are useless because app uses 32bit binaries. This can be viewed in chrome://version. So 64bit devices don't load 64bit binaries and don't provide the performance uplift of 64bit binaries especially in JavaScript operations

@anthonypkeane
Copy link
Collaborator

@anthonypkeane anthonypkeane commented Dec 19, 2019

Google bundles the apk's this way. Thanks

@mthomos
Copy link
Author

@mthomos mthomos commented Dec 19, 2019

Google doesn't provide 64bit binaries for Chrome Stable. Google only provides the 32bit version. Please consider this again because of the extra size without any perf benefit.

@anthonypkeane anthonypkeane transferred this issue from another repository Dec 19, 2019
@anthonypkeane anthonypkeane reopened this Dec 19, 2019
@srirambv srirambv added this to To Do in Android General via automation Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.