Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to connect Crypto Wallet to be connected via private windows only #7496

Open
srirambv opened this issue Dec 20, 2019 · 0 comments
Open

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 20, 2019

Description

Current implementation, Crypto wallet page only opens in normal window(#6706 . Even though the component works on Private tabs by default, when trying to connect to a Dapp it still launches the normal window to connect

Steps to Reproduce

  1. Enable CW on normal window
  2. Open a private tab and visit cryptokitties.co
  3. Connect wallet on private tab, connect account popup opens in a normal tab

Actual result:

Provide option to connect Crypto Wallet to be connected via private windows only

Expected result:

Should open popup window on private tab when the connection was initiated in a private tab

Reproduces how often:

Easy

Brave version (brave://version info)

All component versions

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Related #6637
When MM is enabled to work on PT, it allows a popup on private tab itself
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.