Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards and Shields icons cover URL on right to left languages in URL bar #7552

Open
LaurenWags opened this issue Oct 29, 2019 · 2 comments
Open

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 29, 2019

Description

When using a right to left language, the BAT logo and shields icons are correctly moved to the left side of the URL bar. However, they also cover the URL, so you can't see all of the URL you are on. You are also not able to see the padlock if it is there.

Steps to reproduce

  1. Set device to use R-->L language
  2. Install Brave (can skip onboarding)
  3. Navigate to a site

Actual result

See that the BAT logo and shields icon covers part of the URL and padlock (if it exists) in URL bar

URLbar

Expected result

icons should not obstruct URL bar.

Issue reproduces how often

easily

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86): all
  • Device (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.4.3rc4

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional information

@srirambv srirambv transferred this issue from another repository Dec 30, 2019
@srirambv srirambv added this to To Do in Android General via automation Dec 30, 2019
@anthonypkeane
Copy link
Collaborator

@anthonypkeane anthonypkeane commented Jan 29, 2020

Does it behave the same on Android Tabs @LaurenWags

@LaurenWags
Copy link
Collaborator Author

@LaurenWags LaurenWags commented Jan 29, 2020

@anthonypkeane issue was originally logged for android tabs, looks like @srirambv moved it to this repo per the history on this issue.

@fmarier fmarier added the security label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.