Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & cleanup widevine sig file generation process on Windows #7578

Open
simonhong opened this issue Jan 3, 2020 · 0 comments
Open

Refactor & cleanup widevine sig file generation process on Windows #7578

simonhong opened this issue Jan 3, 2020 · 0 comments

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented Jan 3, 2020

Currently, widevine sig file generation is done separately right after build is finished. https://github.com/brave/brave-browser/blob/master/lib/build.js#L113

Sig file generation script runs with system python because it was hard to resolve external dependencies(cryptography) that is not available from chromium packaged python.

If we can do this during the create installer step during the create_dist, it would be much simpler.
We can try this by installing additional dependencies to brave/vendors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.