Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete contribution queue items #7593

Open
NejcZdovc opened this issue Jan 4, 2020 · 0 comments
Open

Do not delete contribution queue items #7593

NejcZdovc opened this issue Jan 4, 2020 · 0 comments
Labels
QA/No feature/rewards priority/P2
Projects
Rewards Global

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jan 4, 2020 •
edited

We landed this issue/fix #7579. This was temporary fix. The real solution is implement timestamp (completed_at) into contribution_queue. This way we don't need to delete any records and it's safer. GetFirstContributionQueue should now fetch first item from the queue that completed_at is null.
@NejcZdovc NejcZdovc added this to the 1.4.x - Dev milestone Jan 4, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 4, 2020
@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Jan 4, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 4, 2020
Merged
4 of 32 tasks complete
@NejcZdovc NejcZdovc moved this from New Issues to Backlog in Rewards Jan 4, 2020
@NejcZdovc NejcZdovc changed the title Contribution queue is not cleared (1.4 and 1.5) Contribution queue is not cleared (1.4.x and down) Jan 4, 2020
@NejcZdovc NejcZdovc moved this from Backlog to In Progress in Rewards Jan 9, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 9, 2020
Merged
7 of 32 tasks complete
@NejcZdovc NejcZdovc added the QA/No label Jan 9, 2020
@NejcZdovc NejcZdovc changed the title Contribution queue is not cleared (1.4.x and down) Do not delete contribution queue items Jan 10, 2020
@NejcZdovc NejcZdovc removed this from the 1.4.x - Dev milestone Jan 10, 2020
@NejcZdovc NejcZdovc removed the QA/Blocked label Jan 10, 2020
@NejcZdovc NejcZdovc moved this from In Progress to Backlog in Rewards Jan 10, 2020
@NejcZdovc NejcZdovc modified the milestone: 1.5.x - Nightly Jan 10, 2020
@NejcZdovc NejcZdovc added priority/P2 and removed priority/P1 labels Jan 10, 2020
@NejcZdovc NejcZdovc removed their assignment Jan 10, 2020
@NejcZdovc NejcZdovc removed this from Backlog in Rewards Feb 27, 2020
@NejcZdovc NejcZdovc added this to Backlog in Rewards Global via automation Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No feature/rewards priority/P2
Projects
Rewards Global
  
Backlog
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@NejcZdovc
You can’t perform that action at this time.