Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upafter tipping, the banner does not have good keyboard accessibility #7611
Projects
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
After you tip, the "thank you" message is in-line on the tip banner in 1.2.x and above. However, after tipping there is no element highlighted (showing a box around it) to indicate that it is active on the tip banner. This is necessary for accessibility so users can know where they are on the banner. If you tab a bit eventually something will get highlighted, but then you encounter #6986 and leave the tip banner, unable to return via tab.
Steps to Reproduce
Actual result:
Nothing on the tip banner is highlighted w/ a box to indicate where you are - same occurs for both monthly and one time tips:

Expected result:
Something should be highlighted and user selectable via keyboard - perhaps the Share option? This is for product to determine.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @mandar-brave @alexwykoff