Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden override selectors/approach to avoid future regressions #7676

Open
ryanml opened this issue Jan 9, 2020 · 0 comments
Open

Harden override selectors/approach to avoid future regressions #7676

ryanml opened this issue Jan 9, 2020 · 0 comments

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Jan 9, 2020

Per discussion regarding: brave/ethereum-remote-client#104 - we should avoid using CSS index selectors to hide/modify elements as they are likely to break in the future. A better approach if we can't use unique ID's would be to override MM components.

@ryanml ryanml self-assigned this Jan 9, 2020
@ryanml ryanml added this to Untriaged in Crypto Wallets via automation Jan 9, 2020
@bbondy bbondy added the priority/P4 label Jan 10, 2020
@bbondy bbondy moved this from Untriaged to Backlog in Crypto Wallets Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.