Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Security modal appears/disappears several times mentioning MM when connecting to Nano Ledger #7687

Open
kjozwiak opened this issue Jan 10, 2020 · 3 comments

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Jan 10, 2020

Description

When connecting to the Nano Ledger on Windows, you'll get a modal from Windows Security appearing/disappearing several times before CW connects to the Nano Ledger. Example:

Untitled

This also happens with the current CW release.

Steps to Reproduce

  1. launch 1.5.22 CW: 79.0.3945.117 and load brave://wallet
  2. click on I understand on the Welcome to Brave Crypto Wallets modal
  3. create a new wallet and skip the Secret Backup Phrase verification via Remind me later
  4. make sure you have a nano ledger connected and select Connect Hardware Wallet

You'll notice the Windows Security modal when you go through the steps to connect the Ledger

Actual result:

CW

Expected result:

Shouldn't be receiving the Windows Security modal. If it's something new Windows implemented, it should appear once rather than being spammed multiple times.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1909 (Build 18363.535)
Component 0.1.36 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.36

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @ryanml @srirambv

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 10, 2020

Reproduced it on Windows 10 VM but not on the device
image
Issue happens on MM as well so this is not wallet related but OS related
image

Am not sure if this is something that we can avoid or have it fixed. Something at OS level

@srirambv srirambv removed this from the Ethereum Remote Client 1.0.15 milestone Jan 10, 2020
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 10, 2020

@danfinlay this also happens in MetaMask, do you know more about this?

@kjozwiak
Copy link
Member Author

@kjozwiak kjozwiak commented Mar 6, 2020

Seems like this is still happening and it's due to a Windows update. There's a "workaround" via https://support.ledger.com/hc/en-us/articles/360023190873-Fix-for-Windows-10-security-popup but I couldn't get it to work on my machine. It keeps interrupting the transactions making it very difficult to use on Windows.

There's also a blog post as per https://www.ledger.com/your-ledger-device-and-the-upcoming-windows-10-update/.

@bbondy should we close this off or keep it opened so users have some info if they run into the above? Either way works. Leaving it opened probably a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.