Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode doesn't affect window bar/header #7694

Open
habamax opened this issue Jan 10, 2020 · 6 comments
Open

dark mode doesn't affect window bar/header #7694

habamax opened this issue Jan 10, 2020 · 6 comments

Comments

@habamax
Copy link

@habamax habamax commented Jan 10, 2020

Description

Dark mode is not applied to header bar

Steps to Reproduce

  1. turn on dark mode in Win10 and in brave

Actual result:

image

Expected result:

Window header should also be dark

Brave version (brave://version info)

image

Other Additional Information:

I use win10, but had to setup compatibility mode for win8 due to chrome error: https://support.google.com/chrome/thread/22780748?hl=en

@rebron
Copy link
Collaborator

@rebron rebron commented Feb 21, 2020

@habamax Can you try this with our latest 1.3.x and are you using Windows Themes? I'm not seeing this with dark mode on Windows 10 and dark mode in Brave.

@habamax
Copy link
Author

@habamax habamax commented Feb 21, 2020

@habamax Can you try this with our latest 1.3.x and are you using Windows Themes? I'm not seeing this with dark mode on Windows 10 and dark mode in Brave.

image

@rebron
Copy link
Collaborator

@rebron rebron commented Feb 28, 2020

@habamax Are you seeing the same thing in Chrome?

@rebron rebron added the priority/P5 label Feb 28, 2020
@habamax
Copy link
Author

@habamax habamax commented Feb 29, 2020

@habamax Are you seeing the same thing in Chrome?

I don't have chrome installed

@rebron rebron added this to P5 backlog in Front End Mar 3, 2020
@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 14, 2020

@habamax is this still a problem? We have fixed several theme related issues - please let us know

@habamax
Copy link
Author

@habamax habamax commented May 15, 2020

Nope.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P5 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.