Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThe UI should allow for advanced customization #774
Comments
|
Will there ever be progress - as you see many users show interest in features like that or do you plan to stay a generic simple user only browser? At least you could make the black theme fully covering all UI elements, also the right-mouse context menu or the Brave settings menu - Even Chrome is able to do that in the meantime. Or at least to be able to put the tab row beyond the address/url bar - that are very limited basic functionalities, which should at least be considered. |
|
Several +1's from Community -- 4 different users requesting in following thread: |
What would also be nice - and fits to this topic as it belongs to advanced customization - would be an optional REAL status/menu bar - Vivaldi features both. Same like a side-bar. Almost no other Chromium browser features this, would be great if Brave would follow Vivaldi in that way, would also bring over many frustrated(ex-) Firefox power-users towards Brave. I personally use Brave as backup browser after i dumped recently Chromium because of the upcoming Google plan to restrict ads-blocking capability. Would be for sure nice to use Brave a little bit more often, but in that bare-bone kind of way - this makes it impossible for me to do. And there are for sure other potential Brave users which are driven in the end away because of this very same reasoning. So, it would be great if you guys could put stuff like that a little bit under higher priority - and why? Because it benefits in the kind of way that your user number is only growing more :) |
|
I don't know if the info contained in the issue referenced by the OP is still relevant, but if Brave's UI is still largely HTML/CSS/JS code, it should be easy to allow for some heavy customization. Alternatively it would make sense for me to give at least some degree of flexibility to the power user. It would not have to be "easy to use", as most regular user wouldn't care for it anyway, but it should be still accessible if one has the time and patience to hack it a bit. I miss the possibility to make my browser truly my own, like it was possible to do with older versions of Firefox. |
|
@Arandhras unfortunately the UI is not HTML/CSS/JS anymore- it's all C++ using Chromium views. It's quite a bit harder to edit, but definitely doable (we want to do it- work hasn't been prioritized, as far as I know). |
@bsclifton Why not making a compromise and delivering priority in a fair share to all elements Brave related? A real menu or full status bar would be good for a start ;) |
|
@bsclifton It could be worked out like what wxWidgets does with its XRC system ( https://docs.wxwidgets.org/3.0/overview_xrc.html ): the whole UI is defined as a set of scripts (in Wx's case, XML... but it could be anything) that each describe a hierarchy of panes, dialogs and widgets. You don't have to redefine behavior, just size, positioning, color etc. Once you have this system in place, all you need is to modify such scripts. Using non-executable file formats such as XML or JSON has the benefit of not allowing potentially malicious stuff being run in the user's browser. |
|
Yes please for the love of all let us move or remove the bookmark button! Terrible placement! |
Really, where do I find the ui code? There is an ui repo with reusable elements, which is written in typescript ... and in brave-core I find js, css and html code in the ui folder https://github.com/brave/brave-core/tree/master/ui By the way, is it possible (or do you appreciate) help from the community like pull request regarding new ui features/changes. And if so, is there a guide to get started showing things like the project structure etc. |
|
@Leon0402 the parts that are in JavaScript/TypeScript are part of the Brave UI library. These are basically used on Web UI pages (settings, rewards, etc) For the browser chrome itself (back/forward/refresh buttons, etc), you'll have to go through the code to find the appropriate view to edit. A good example to look at is how @petemill and @mkarolin did the Lion and Rewards icons inside the omnibox: There are some advanced command-line options you can use like I created a task a while back to setup proper documentation for onboarding new developers. I'll try my best to make some progress on this over the weekend Help is DEFINITELY appreciated and welcome from the community |
|
@bsclifton thanks for your answer! To be honest, I haven't really realised yet that settings, rewards etc. are web ui pages. Is there any reason for this? Don't know much about this, but I guess consistency is always a good thing and therefore everything should be created in C++? It's great that you want the community to help with the project! I guess, setting up a wiki post is a good first start :) Furthermore it would be of course great to have something like a Telegram group, irc channel, mailing list ... for questions. Because as far as I can see, the forum is more user-oriented and not for developers. Brave personally seems a very good project to invest some of my time in. Although I'm not sure if I'm experienced enough for this as I never worked with the chrome ui, but with qt instead (and also do not have 20 years of experience in programming). But everyone has to start somewhere ;) |
Yes! There's a reason for this! Location matters! We subconsciously expect UI concepts like buttons to be grouped by some sort of category.
All other buttons before the address bar are NAVIGATION buttons. This makes the bookmark button out of place there. Also, having less than 4 buttons together is better to make you immediately find what you want, since those are the most important buttons in a browser. Note that I would even go further and split up the menu into browser-menu and page-menu. So, even if you don't allow customization, at least this would be a way better layout. |
|
+1 from @mohistmen via #7386
|
|
You see, quite a lot of people want more customization abilities. So the question is, will you guys implement them or will you ignore this request? |
|
Nope, I will never ignore it.
…------------------ 原始邮件 ------------------
发件人: "Sajadi"<notifications@github.com>;
发送时间: 2020年1月17日(星期五) 凌晨1:15
收件人: "brave/brave-browser"<brave-browser@noreply.github.com>;
抄送: "496173298"<496173298@qq.com>; "Mention"<mention@noreply.github.com>;
主题: Re: [brave/brave-browser] The UI should allow for advanced customization (#774)
You see, quite a lot of people want more customization abilities. So the question is, will you guys implement them or will you ignore this request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
When is Brave finally starting to deliver customization features which are meant for power users? So far Brave serves only the simple users. |
Carried over from brave/browser-laptop#246
The idea would be to allow users to customize the location of features like the URL bar, bookmarks toolbar, tabs, etc.
Original issue details:
Some other requested functionality: