Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button not shown on certain videos #7770

Open
srirambv opened this issue Mar 13, 2019 · 5 comments
Open

Tip button not shown on certain videos #7770

srirambv opened this issue Mar 13, 2019 · 5 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Mar 13, 2019

Description

Issue found by @jamesmudgett
Tip button not shown on certain videos.

Steps to Reproduce

Scenario 1

  1. Open YT
  2. Search for "texaswest"
  3. Tap on channel name
  4. Open the fist video, no tip button shown for the publishers on br panel

Scenario 2

  1. Copy https://m.youtube.com/watch?v=UvJl202PlNI
  2. Open new tab and paste the video url
  3. Tip button doesn't show on the video
  4. Go to user channel and load any other video, tip button shows up

Actual result:

Tip button not shown on certain videos

Expected result:

Tip button should be shown on all links irrespective of how its opened

Issue reproduces how often:

Easy

Issue happens on:

  • Current Playstore version?
  • Beta build?

Device Details:

  • Install Type(ARM, x86):
  • Device(Phone, Tablet, Phablet):
  • Android Version:

Brave version:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 14, 2019

@SergeyZhukovsky reproducible on desktop using the following build which is the latest release:

Note: Went through the Copy/Paste case

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Example of the issue occurring on a clean 0.61.51 Chromium: 73.0.3683.75 install:

Screen Shot 2019-03-14 at 2 32 46 AM

@SergeyZhukovsky as you mentioned in Slack, they share a shared library so the same issue is also present on desktop. @NejcZdovc in the above situation, where should the fix go into first? Desktop and work its way into android? Should I file a new issue on https://github.com/brave/brave-browser/?

CCing @LaurenWags.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Mar 14, 2019

@kjozwiak is this reproducible on the latest dev?

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 14, 2019

@NejcZdovc yup, seeing the same thing happen on the following dev build:

Brave 0.63.8 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Example of the issue happening:

Screen Shot 2019-03-14 at 12 01 17 PM

I left it running for ~5min and never ended up getting any of the tipping UI within the panel. On desktop, STR:

  • launch 0.63.8 Chromium: 73.0.3683.75 & enable rewards via the panel
  • copy/paste https://m.youtube.com/watch?v=UvJl202PlNI into the URL
  • video will start playing, click on the BAT icon and you'll notice there's no tipping UI being displayed
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Mar 14, 2019

@kjozwiak can you please file an issue for it. Thank you

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 20, 2019

@kjozwiak can you please file an issue for it. Thank you

Created #3800 👍

@anthonypkeane anthonypkeane transferred this issue from another repository Jan 16, 2020
@anthonypkeane anthonypkeane added this to New Issues in Rewards via automation Jan 16, 2020
@NejcZdovc NejcZdovc moved this from New Issues to Icebox - Android in Rewards Feb 27, 2020
@NejcZdovc NejcZdovc moved this from Icebox - Android to Icebox - Desktop in Rewards Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Icebox
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.