Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show monthly tip amount for creators in rewards panel #7779

Open
jamesmudgett opened this issue Mar 20, 2019 · 8 comments
Open

Show monthly tip amount for creators in rewards panel #7779

jamesmudgett opened this issue Mar 20, 2019 · 8 comments

Comments

@jamesmudgett
Copy link

@jamesmudgett jamesmudgett commented Mar 20, 2019

Missing feature:

When tipping and checking making this tip monthly we need to show screen as seen below:

54729754-80a91480-4b42-11e9-953e-6b7a023c6085

54729755-8272d800-4b42-11e9-810a-ef6367a670ef

@gdregalo
Copy link
Collaborator

@gdregalo gdregalo commented Mar 22, 2019

@jamesmudgett 'checking' = AC ?

@jamesmudgett
Copy link
Author

@jamesmudgett jamesmudgett commented Mar 22, 2019

@gdregalo updated screens

@gdregalo
Copy link
Collaborator

@gdregalo gdregalo commented Mar 22, 2019

Per @NejcZdovc :
If you have AC off, but recurring tip we will show only one line with that drop down.
(we need to show the grouping lines on the top and bottom)

if you have AC on and recurring then we will show all 3 of them.
if AC is on, but not recurring we only show % and include toggle.

@jamesmudgett
Copy link
Author

@jamesmudgett jamesmudgett commented Mar 22, 2019

@gdregalo thanks for clearing that up!

@gdregalo
Copy link
Collaborator

@gdregalo gdregalo commented Mar 27, 2019

2019-03-27 11_14_24-Window

@jamesmudgett @NejcZdovc
The image near the Recurrent Donations drop down list is more suitable to increase/decrease the value in the buddy edit box when user presses upper or lower part of the button.

I think the native drop down list button image looks much more intuitively clear.
Screenshot_2019-03-26-20-09-07

@gdregalo
Copy link
Collaborator

@gdregalo gdregalo commented Mar 30, 2019

Per @jamesmudgett:
I believe I attached an image before which is just a drop down arrow. You could also use the one in your comment, looks good as well. I agree, shouldn’t be an up and down arrow.

@gdregalo gdregalo closed this Mar 30, 2019
@gdregalo
Copy link
Collaborator

@gdregalo gdregalo commented Apr 9, 2019

There is an issue when dropdown spinner is inflated on PopupWindow (API 24).

@gdregalo gdregalo reopened this Apr 9, 2019
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Apr 11, 2019

@anthonypkeane is this still planned for prod release?

@anthonypkeane anthonypkeane transferred this issue from another repository Jan 16, 2020
@anthonypkeane anthonypkeane added this to New Issues in Rewards via automation Jan 16, 2020
@NejcZdovc NejcZdovc moved this from New Issues to Icebox - Android in Rewards Feb 27, 2020
@NejcZdovc NejcZdovc moved this from Icebox - Android to Icebox - Desktop in Rewards Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Icebox
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.