Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab count clashing with URL in private tabs #7835

Open
mfsoftworks opened this issue Jan 21, 2020 · 4 comments
Open

Tab count clashing with URL in private tabs #7835

mfsoftworks opened this issue Jan 21, 2020 · 4 comments

Comments

@mfsoftworks
Copy link

@mfsoftworks mfsoftworks commented Jan 21, 2020

Description

Currently in private tabs, the tab count is displayed over the URL with a transparent background so any long URL is shown with the tab count on top making readability difficult

Steps to reproduce

  1. Open private tabs
  2. Go to any sufficiently long URL to fill the full URL bar

Actual result

Tab count is displayed over URL with the URL underneath making legibility low

Expected result

Tab count is displayed separately from the URL to be easy to read

Issue reproduces how often

Every time a long URL is opened in private tabs

Issue happens on

  • Current Play Store version

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 9

Brave version

1.7.0

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 21, 2020

This is only an issue when bottom toolbar is disabled. This needs to be checked on beta as well.

@srirambv srirambv transferred this issue from another repository Jan 21, 2020
@srirambv srirambv added this to To Do in Android General via automation Jan 21, 2020
@mfsoftworks
Copy link
Author

@mfsoftworks mfsoftworks commented Jan 21, 2020

This is only an issue when bottom toolbar is disabled. This needs to be checked on beta as well.

You're right, I have bottom bar disabled to increase view space, with bottom bar it's fine

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 21, 2020

This issue will most probably be fixed on beta.

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 22, 2020

This needs to be fixed on core as well. Here's a screenshot on the latest nightly build
image

We need to move the tab count outside the URL similar to how it looks on normal window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.