Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text update needed on Dashboard Settings #7947

Open
LaurenWags opened this issue Jan 28, 2020 · 2 comments
Open

text update needed on Dashboard Settings #7947

LaurenWags opened this issue Jan 28, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Jan 28, 2020

Description

Per the spec for SNTP, Show Background Image should be updated to Show Background Images.

Steps to Reproduce

  1. Clean profile
  2. Enable SNTP from flags, relaunch
  3. Open Dashboard Settings on NTP

Actual result:

Screen Shot 2020-01-27 at 7 32 55 PM

Expected result:

Should say Show Background Images

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @petemill

@rebron rebron added this to Untriaged backlog in New Tab page Jan 28, 2020
@rebron rebron moved this from Untriaged backlog to P4 backlog in New Tab page Jan 28, 2020
@rebron rebron moved this from P4 backlog to P3 backlog in New Tab page Jan 28, 2020
@rebron rebron moved this from P3 backlog to In progress in New Tab page Jan 28, 2020
@rebron rebron moved this from In progress to P3 backlog in New Tab page Jan 28, 2020
@rebron rebron moved this from P3 backlog to P5 backlog in New Tab page Jan 28, 2020
@rebron rebron moved this from P5 backlog to P4 backlog in New Tab page Jan 28, 2020
@gupta437
Copy link

@gupta437 gupta437 commented Mar 21, 2020

If no one is working actively on this issue, Can I take this issue to work on?

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 23, 2020

@gupta437 it's all yours! 😄 Let me know if you need help finding where it's stored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
New Tab page
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.