Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access to the private Apple entitlement for Chromium PWAs: com.apple.developer.associated-domains.applinks.read-write #8027

Open
mbacchi opened this issue Feb 3, 2020 · 5 comments
Assignees
Labels

Comments

@mbacchi
Copy link
Member

@mbacchi mbacchi commented Feb 3, 2020

As of Chromium 80, there is a private Apple entitlement that is used for PWA support. It caused us trouble when signing Chromium 80 last week, and we added this patch as a workaround for the short term to remove the entitlement. The Chromium team pointed out that they announced this in the Chromium Embedders google group(which many of us are now members of.)

To properly add support for this, we need to contact Apple and request to be whitelisted for the com.apple.developer.associated-domains.applinks.read-write entitlement.

@mbacchi mbacchi self-assigned this Feb 3, 2020
@mbacchi
Copy link
Member Author

@mbacchi mbacchi commented Feb 11, 2020

Requested access to this entitlement via an Apple Developer portal TSI (Technical Support request), waiting to hear back from them.

@mbacchi
Copy link
Member Author

@mbacchi mbacchi commented Feb 18, 2020

Have not heard anything from Apple support since the initial ticket acknowledgement.

@mbacchi
Copy link
Member Author

@mbacchi mbacchi commented Feb 24, 2020

Sent a follow up email to Apple Developer Technical Support to inquire about the status of this request after chatting with an Apple employee. Will comment here as soon as I hear something.

@mbacchi
Copy link
Member Author

@mbacchi mbacchi commented Mar 2, 2020

I have not heard anything officially from Apple Developer Technical Support, but my Apple contact has said that we should have access to the entitlement now if we update our provisioning profile. I will inquire from DTS to find out if this applies to all of our channel provisioning profiles.

@mbacchi
Copy link
Member Author

@mbacchi mbacchi commented Mar 6, 2020

Received this from Apple Developer Technical Support earlier in the week:

I confirm the entitlement has been granted.
...
You’ll need to add the entitlement to your profiles and re-generate them. Then you’ll need to rebuild your app with the newly generated profile.
...
Since this entitlement is for making universal links work with the Brave browser, you need several pieces to work together. Your app will need to check if it is launched by the user when clicking on a URL, if that URL is a universal link. This is done by using the SFUniversalLink API. If it is a universal link, the app should display UI to ask the user if they want the link opened in the linked app, or in the Brave browser.

After rebuilding your app with the profile that contains the new entitlement, here is the process I’d use to test:

  1. Set the Brave browser (that you just built) to be the default in the System Preferences > General tab.
  2. Install the Twitter for macOS app from the Mac App Store. Sign into your Twitter account, and make sure the app is working correctly.
  3. In notes type “http://twitter.com” and press return.
  4. Click the resulting link in Notes.
  5. Brave should open with some UI that you implemented asking if the user wanted to open the link in the Twitter app.

This response includes a confirmation that our entitlement has been granted, answers to my questions about whether it was granted for all of our provisioning profiles, and instructions on how to test it is in fact working after building with the new profile(s).

I will leave this open for the moment but will shortly open an issue to require using these new entitlements.

CC: @bsclifton @bridiver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.