Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching theme doesn't update CW page #8028

Closed
srirambv opened this issue Feb 3, 2020 · 1 comment
Closed

Switching theme doesn't update CW page #8028

srirambv opened this issue Feb 3, 2020 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 3, 2020

Description

Switching theme doesn't update CW page

Steps to Reproduce

  1. Set browser theme to dark
  2. Load 0.1.37 component
  3. Ensure Dark theme is used for CW
  4. Switch browser theme to light
  5. CW doesn't change theme need to reload page to switch to light

Actual result:

Switching theme doesn't update CW page

Expected result:

Should auto switch

Reproduces how often:

Easy with compoent sideload

Brave version (brave://version info)

Component 0.1.37

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Switching from light to dark works fine but dark to light doesn't. May also need to test this after component is released

@srirambv srirambv added this to Untriaged in Crypto Wallets via automation Feb 3, 2020
@ryanml ryanml self-assigned this Feb 3, 2020
@ryanml ryanml added this to the Ethereum Remote Client 1.0.16 milestone Feb 3, 2020
Crypto Wallets automation moved this from Untriaged to Done Feb 4, 2020
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Feb 6, 2020

Verification passed on

Brave 1.5.76 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.41
  • Verified switching theme from settings automatically updates CW page as well
    vokoscreen-2020-02-06-09-44-26

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42
  • Verified switching theme from settings automatically updates CW page as well
    cwtheme

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42
  • Verified switching theme from settings automatically updates CW page as well
    cwdark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Shipped
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.