Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading childNodes logging behaviour #8093

Open
ABCbum opened this issue Feb 6, 2020 · 4 comments
Open

Misleading childNodes logging behaviour #8093

ABCbum opened this issue Feb 6, 2020 · 4 comments
Labels
Chromium/waiting upstream feature/dev-tools repros-on-chrome
Projects
Chromium Rebasing

Comments

@ABCbum
Copy link

@ABCbum ABCbum commented Feb 6, 2020

Description

Brave logs a misleading message on devtools. NodeList has [div] inside but length is 0 and doesn't have anything inside the array. I don't know if this is a default common behaviour or not but this is really confusing to me.

image

Steps to Reproduce

  1. I opened index.html with the following code on Brave:
<html>
  <body>
     <div id="list"></div>
     <script>
        const list = document.getElementById("list");
        const node = document.createElement("div");

        list.appendChild(node);
        console.log(list.childNodes);
        list.removeChild(node);
      </script>
  </body>
</html>
  1. Open devtools console.

Actual result:

Provided on Description section.

Expected result:

NodeList array to have div element inside and length being 1.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave: 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision: 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS: Windows 10 OS Version 1903 (Build 18362.592)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? Yes.
  • Can you reproduce this issue with the dev channel? Yes.
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA.
  • Does the issue resolve itself when disabling Brave Rewards? NA.
  • Is the issue reproducible on the latest version of Chrome? Yes.

Miscellaneous Information:
@rebron
Copy link
Collaborator

@rebron rebron commented Mar 27, 2020

@ABCbum Is this still an issue on 1.5.115? We've had quite a few chromium updates since then.
@rebron rebron changed the title Misleading chileNodes logging behaviour Misleading childNodes logging behaviour Mar 27, 2020
@ABCbum
Copy link
Author

@ABCbum ABCbum commented Mar 28, 2020 •
edited

Hi @rebron , i can confirm that this is still an issue in current version (Version 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)). It is fine with the initial load but if i reload then the bug still comes back.

image

Thanks!!
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 28, 2020

Is the issue reproducible on the latest version of Chrome? Yes.

@ABCbum assuming it's still an issue in the last Chrome as well? Sounds like you also reproduced it on Chrome originally as per the above.
@ABCbum
Copy link
Author

@ABCbum ABCbum commented Mar 29, 2020

@ABCbum assuming it's still an issue in the last Chrome as well?

@kjozwiak , yes i can reproduce it on Chrome (Version 81.0.4044.83 (Official Build) beta (64-bit)) the behaviour is exactly the same, fine with the initial load but reload then it's wrong. Thanks!
@bsclifton bsclifton added this to Needs triage in Chromium Rebasing via automation Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chromium/waiting upstream feature/dev-tools repros-on-chrome
Projects
Chromium Rebasing
  
Needs triage
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@kjozwiak @bsclifton @rebron @ABCbum
You can’t perform that action at this time.