Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upeth_signTypedData in brave crypto wallet renders without confirm button #8223
Projects
Milestone
Comments
|
Verification passed on
|
| Brave | 1.6.51 Chromium: 80.0.3987.116 (Official Build) dev (64-bit) |
|---|---|
| Revision | dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917} |
| OS | Windows 10 OS Version 1803 (Build 17134.523) |
| Component | 0.1.47 |
Verification passed on
| Brave | 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit) |
|---|---|
| Revision | cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943} |
| OS | macOS Version 10.15.1 (Build 19B88) |
| Component | 0.1.47 |
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment





Description
When using JSON RPC for eth_signTypedData in brave crypto wallet the wallet renders the JSON of the message to be signed, but a confirm button isn't rendered.
Steps to Reproduce
Actual result:
When signing, the bottom of the signature gets cut off, and can not be confirmed or cancelled
Expected result:
The confirm and cancel buttons would be displayed, as happens here when clicking "Click here to sign some typed data": https://weijiekoh.github.io/eip712-signing-demo/index.html
Reproduces how often:
Whenever the message is too large to be displayed in the frame, the confirm and cancel buttons get cut off. It seems that the issue is a CSS issue within the wallet that doesn't account for large signTypedData payloads.
Brave version (brave://version info)
Brave | 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | macOS Version 10.14.5 (Build 18F132)