Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Variation on Windows and Android #8272

Open
jonathansampson opened this issue Feb 16, 2020 · 3 comments
Open

Default Variation on Windows and Android #8272

jonathansampson opened this issue Feb 16, 2020 · 3 comments
Assignees

Comments

@jonathansampson
Copy link

@jonathansampson jonathansampson commented Feb 16, 2020

Description

Field Trials are, AFAIK, disabled in Brave. That said, Brave on Windows and Android still enumerate a single variation when you visit about:version. This variation appears to be a fallback sampling trial, as found here:

// Create a field trial to control metrics/crash sampling for Stable on
// Windows/Android if no variations seed was applied.
void CreateFallbackSamplingTrialIfNeeded(base::FeatureList* feature_list) {
#if defined(OS_WIN) || defined(OS_ANDROID)
    ChromeMetricsServicesManagerClient::CreateFallbackSamplingTrial(
        chrome::GetChannel(), feature_list);
#endif  // defined(OS_WIN) || defined(OS_ANDROID)
}

Steps to Reproduce

  1. Visit about:version
  2. Note variations

Actual result:

5e3a236d-4113a79e is present in the Stable release:
5e3a236d-59e286d0 is present in all other builds:

Expected result:

Unsure, but our options are:

  1. Variation should be removed
  2. macOS should be included
  3. We do nothing, and leave as-is

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome? Yes
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 17, 2020

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 19, 2020

@bsclifton probably good to have 2 issues one for desktop and one for Android if there needs to be QA done for this

@jumde
Copy link
Contributor

@jumde jumde commented Feb 28, 2020

@bsclifton @bbondy - Android build is in progress, will try to wrap this up today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.