Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons on top tiles removed message needs padding #8282

Closed
srirambv opened this issue Feb 17, 2020 · 1 comment · Fixed by brave/brave-core#4668
Closed

Buttons on top tiles removed message needs padding #8282

srirambv opened this issue Feb 17, 2020 · 1 comment · Fixed by brave/brave-core#4668

Comments

@srirambv
Copy link
Contributor

Description

Buttons on top tiles removed message needs padding

Steps to Reproduce

  1. Add top tiles
  2. Remove one of the top tiles
  3. Buttons on the top tiles removed message doesn't have padding

Actual result:

image

Expected result:

Should have proper padding

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cezaraugusto @petemill
@brave/legacy_qa to check on other platforms

cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 17, 2020
@rebron rebron added this to Untriaged backlog in New Tab page Feb 26, 2020
@bsclifton bsclifton added this to the 1.7.x - Nightly milestone Mar 2, 2020
@kjozwiak kjozwiak modified the milestones: 1.7.x - Nightly, 1.5.x - Beta Mar 2, 2020
@rebron rebron moved this from Untriaged backlog to P3 backlog in New Tab page Mar 3, 2020
@rebron rebron moved this from P3 backlog to In progress in New Tab page Mar 3, 2020
@rebron rebron moved this from In progress to Completed in New Tab page Mar 3, 2020
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Mar 4, 2020

Verification passed on

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
  • Top tiles removed message has proper padding, verified both clean and upgraded profile
    image

Verification passed on

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image


Verified passed with

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-03-04 at 9 08 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment