Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Autoplay list, match chromium behavior #8408

Closed
pes10k opened this issue Feb 26, 2020 · 8 comments
Closed

Remove Autoplay list, match chromium behavior #8408

pes10k opened this issue Feb 26, 2020 · 8 comments

Comments

@pes10k
Copy link
Contributor

@pes10k pes10k commented Feb 26, 2020

Background

Brave currently ships with a list of domains that can autoplay video and audio; sites on the list can, everyone else cannot. This is a usability / perf feature, originally put in out of dissatisfaction with how Chrome was handling autoplay.

Problem

This breaks a bunch of sites. The list isn't maintained, its not anyone's direct responsibility. Chromium has also caught up. I super don't dig the "site engagement score" system Chromium uses for making determinations here, but since its not a privacy / security issue, I dont have strong concerns.

Suggestion

  1. Remove Brave autoplay infrastructure
  2. Just do what chromium does
  3. (only if its quick) include ability for short term escape hatch, DAT-shipped settings for chromium-determined-overrides (e.g. "example.org" -> "always autoplay", "evil.org" -> "never autoplay", etc)

Spec: https://docs.google.com/document/d/16nicZYs8uf-CLNJc0FrIucwwhzajJ9IL0yUbyCpajBM/edit#

@pes10k
Copy link
Contributor Author

@pes10k pes10k commented Feb 26, 2020

cc: @rebron

@pes10k
Copy link
Contributor Author

@pes10k pes10k commented Feb 26, 2020

@BrendanEich
Copy link
Member

@BrendanEich BrendanEich commented Feb 26, 2020

Is anyone able to evaluate whether this leaves things autoplaying that shouldn't be? I'm in favor but want some kind of spot check if not audit.

@pes10k
Copy link
Contributor Author

@pes10k pes10k commented Feb 26, 2020

Talked with @ryanbr today, and he has heroically volunteered to do some manual eval of the diff.

So, sorted :)

@rebron rebron added this to Untriaged Backlog in General Mar 3, 2020
@rebron rebron added the priority/P3 label Mar 3, 2020
@pes10k pes10k added the privacy-pod label Mar 6, 2020
@pes10k pes10k mentioned this issue Mar 6, 2020
7 of 32 tasks complete
@rebron rebron moved this from Untriaged Backlog to In progress in General Mar 9, 2020
General automation moved this from In progress to Completed Mar 17, 2020
@rebron rebron added this to the 1.8.x - Nightly milestone Mar 18, 2020
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Apr 9, 2020

@pes10k @pilgrim-brave could one of you review and determine if this issue requires manual QA? if so, please add QA/Yes label and a test plan. If not, please add QA/No label. Thanks! cc @kjozwiak

@pes10k
Copy link
Contributor Author

@pes10k pes10k commented Apr 9, 2020

I believe @pilgrim-brave added automated tests, so i think it shouldn't be needed, but he should confirm

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Apr 21, 2020

@pilgrim-brave pinging on #8408 (comment) and #8408 (comment) - could you take a look please? Thanks! cc @kjozwiak @bsclifton

@pilgrim-brave
Copy link

@pilgrim-brave pilgrim-brave commented Apr 22, 2020

Yes, autoplay behavior is covered by automated tests.

@rebron rebron changed the title Remove Autoplay list, just do what chromium does Remove Autoplay list, match chromium behavior Apr 27, 2020
@rebron rebron removed this from Completed in General May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.