Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Autoplay list, match chromium behavior #8408
Comments
|
cc: @rebron |
|
relevant chrome-side documentation
|
|
Is anyone able to evaluate whether this leaves things autoplaying that shouldn't be? I'm in favor but want some kind of spot check if not audit. |
|
Talked with @ryanbr today, and he has heroically volunteered to do some manual eval of the diff. So, sorted :) |
|
@pes10k @pilgrim-brave could one of you review and determine if this issue requires manual QA? if so, please add |
|
I believe @pilgrim-brave added automated tests, so i think it shouldn't be needed, but he should confirm |
|
@pilgrim-brave pinging on #8408 (comment) and #8408 (comment) - could you take a look please? Thanks! cc @kjozwiak @bsclifton |
|
Yes, autoplay behavior is covered by automated tests. |
Background
Brave currently ships with a list of domains that can autoplay video and audio; sites on the list can, everyone else cannot. This is a usability / perf feature, originally put in out of dissatisfaction with how Chrome was handling autoplay.
Problem
This breaks a bunch of sites. The list isn't maintained, its not anyone's direct responsibility. Chromium has also caught up. I super don't dig the "site engagement score" system Chromium uses for making determinations here, but since its not a privacy / security issue, I dont have strong concerns.
Suggestion
Spec: https://docs.google.com/document/d/16nicZYs8uf-CLNJc0FrIucwwhzajJ9IL0yUbyCpajBM/edit#