Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet dark theme final follow up #8425

Open
srirambv opened this issue Feb 27, 2020 · 1 comment
Open

Crypto Wallet dark theme final follow up #8425

srirambv opened this issue Feb 27, 2020 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 27, 2020

Description

Crypto Wallet dark theme final follow up

Actual result:

H/w Address selection
image

Token Auto fill selection
image

Account connection linkage
image

Expected result:

One fix for three issues and hopefully upstream support for theming

Reproduces how often:

Easy

Brave version (brave://version info)

Component : 0.1.47

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Feb 27, 2020

Sign contract window doesn't show text in dark theme. Found while testing #8223
image

@bbondy bbondy added this to the Ethereum Remote Client 1.0.18 milestone Feb 28, 2020
@bbondy bbondy moved this from Untriaged to Backlog in Crypto Wallets Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.