Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions can be signed from the incorrect ledger account #8530

Closed
ryanml opened this issue Mar 4, 2020 · 1 comment
Closed

Transactions can be signed from the incorrect ledger account #8530

ryanml opened this issue Mar 4, 2020 · 1 comment

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Mar 4, 2020

This is a fix we need to pull in upstream via: MetaMask/eth-ledger-bridge-keyring#14

STR:

  1. Connect a Ledger account > 1 (e.g. the 2nd account)
  2. Confirm that sending a transaction is signed correctly
  3. Reload MetaMask (or, for non-MM, construct a new instance from serialized state)
  4. Confirm that sending a transaction is signed with the 1st account on the Ledger (an incorrect account)

Expected:

  1. Connect a Ledger account > 1 (e.g. the 2nd account)
  2. Confirm that sending a transaction is signed correctly
  3. Reload MetaMask (or, for non-MM, construct a new instance from serialized state)
  4. Confirm that sending a transaction is signed with the 2nd account on the Ledger (the correct account)
@ryanml ryanml added this to the Ethereum Remote Client 1.0.17 milestone Mar 4, 2020
@ryanml ryanml self-assigned this Mar 4, 2020
@ryanml ryanml added this to Untriaged in Crypto Wallets via automation Mar 4, 2020
@ryanml ryanml moved this from Untriaged to Done in Crypto Wallets Mar 4, 2020
@kjozwiak kjozwiak closed this Mar 4, 2020
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 6, 2020

Verification PASSED on macOS 10.15.3 x64 (Catalina) using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.51

Brave | 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | macOS Version 10.15.3 (Build 19D76)
  • Verified the STR outlined via #8530 (comment)
  • ensured that connected to a Ledger HW device worked without any issues
  • ensured that sending ERC20 tokens from the Ledger into a CW & MM accounts worked
  • ensured that receiving ERC20 tokens from CW & MM accounts into the Ledger HW worked

Verification PASSED on Mint 19.1 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.51

Brave | 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
--- | ---
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | Linux
  • Verified the STR outlined via #8530 (comment)
  • ensured that connected to a Ledger HW device worked without any issues
  • ensured that sending ERC20 tokens from the Ledger into a CW & MM accounts worked
  • ensured that receiving ERC20 tokens from CW & MM accounts into the Ledger HW worked

Verification PASSED on Win 10 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.51

Brave | 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
--- | ---
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | Windows 10 OS Version 1909 (Build 18363.693)
  • ensured that connected to a Ledger HW device worked without any issues
  • ensured that sending ERC20 tokens from the Ledger into a CW & MM accounts worked
  • ensured that receiving ERC20 tokens from CW & MM accounts into the Ledger HW worked

Couldn't go through the above cases on Win x64 due to running into #7687. Unfortunately the work around specified under https://support.ledger.com/hc/en-us/articles/360023190873-Fix-for-Windows-10-security-popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Shipped
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.