Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DHT client in WebTorrent for supporting trackless torrents #857

Closed
yrliou opened this issue Aug 27, 2018 · 2 comments
Closed

Enable DHT client in WebTorrent for supporting trackless torrents #857

yrliou opened this issue Aug 27, 2018 · 2 comments
Assignees
@yrliou
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/webtorrent
Milestone
0.55.x - Release ...

Comments

@yrliou
Copy link
Member

@yrliou yrliou commented Aug 27, 2018

In bittorrent-dht, it's using nodejs's dns.lookup, we should provide our own shim to use chromium's existing API or implemented one if none exists.
@yrliou yrliou mentioned this issue Aug 27, 2018
Merged
5 of 11 tasks complete
@bbondy bbondy added this to the Backlog milestone Aug 29, 2018
@yrliou yrliou changed the title Support of trackless torrents using bittorrent-dht/client Enable DHT client in WebTorrent for supporting trackless torrents Sep 12, 2018
@yrliou yrliou mentioned this issue Sep 12, 2018
Merged
3 of 11 tasks complete
@yrliou yrliou self-assigned this Sep 12, 2018
@yrliou yrliou modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 12, 2018
@bbondy bbondy added this to WebTorrent in 0.55.x - Release Sep 13, 2018
@bbondy bbondy removed this from WebTorrent in 0.55.x - Release Sep 24, 2018
@yrliou
Copy link
Member Author

@yrliou yrliou commented Sep 27, 2018

QA note: See brave/brave-core#443 for the test plan.
@yrliou yrliou added QA/Yes and removed QA/Test-Plan-Required labels Sep 27, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 5, 2018 •
edited by LaurenWags

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux and Windows
  • Verified webtorrent is loaded and able to connect to peers and download the file

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
  • modified test plan from brave/brave-core#443 slightly, due to #1435. Verified issue by opening Dev Tools and running the following command: window.open("magnet:?xt=urn:btih:dd8255ecdc7ca55fb0bbf81323d87062db1f6d1c&dn=Big+Buck+Bunny"). Then I was able to start the download and locate peers.
@srirambv srirambv mentioned this issue Oct 5, 2018
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Feb 18, 2019
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2019
Open
This was referenced Feb 18, 2019
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Feb 18, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Feb 18, 2019
Closed
@srirambv srirambv mentioned this issue Feb 18, 2019
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Feb 18, 2019
Closed
This was referenced Feb 19, 2019
Open
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Feb 19, 2019
Closed
This was referenced Feb 19, 2019
Closed
Closed
This was referenced Feb 19, 2019
Closed
Open
This was referenced Feb 20, 2019
Closed
Closed
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 20, 2019
Closed
@srirambv srirambv mentioned this issue Feb 20, 2019
Closed
This was referenced Feb 20, 2019
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Feb 20, 2019
Closed
This was referenced Feb 20, 2019
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Feb 21, 2019
Closed
@btlechowski btlechowski mentioned this issue Feb 21, 2019
Closed
@tortino tortino mentioned this issue Feb 23, 2019
Open
@jnki jnki mentioned this issue Feb 26, 2019
Closed
This was referenced Feb 27, 2019
Closed
Closed
@CamelCaseName CamelCaseName mentioned this issue Feb 27, 2019
Closed
@FirefoxWas FirefoxWas mentioned this issue Feb 28, 2019
Closed
@Shaomada Shaomada mentioned this issue Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/webtorrent
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Enable DHT client in WebTorrent
4 participants
@bbondy @yrliou @srirambv @LaurenWags
You can’t perform that action at this time.