Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ad notifications are not shown on Windows until notifications are authorized #8843

Open
tmancey opened this issue Mar 24, 2020 · 1 comment

Comments

@tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 24, 2020

Description

Brave Ad notifications are not shown on Windows until notifications are authorized

Steps to Reproduce

  1. View an ad notification

Actual result:

Ad notification is not shown on Windows until notifications are authorized, i.e. visiting http://bennish.net/web-notifications.html and clicking "Allow", i.e.

Screenshot 2020-03-24 at 19 21 16

I could not reproduce the issue after uninstalling Brave Browser and installing version 1.5.115 (Chromium: 80.0.3987.149 (Official Build) (64-bit). The only difference I could see was that Brave appeared in "Notifications & actions" within Windows settings whereas before I uninstalled the older build this option was missing

Expected result:

Ad notification should be shown on Windows

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[9836:10792:0324/102454.662:INFO:notification_helper_win.cc(208)] Notifications are disabled

appeared in the debug logs caused by src/chrome/browser/notifications/notification_platform_bridge_win.cc failing with Unable to initialize toast notifier

@tmancey tmancey added this to New issues in Ads via automation Mar 24, 2020
@rebron rebron added the priority/P2 label Mar 27, 2020
@tmancey tmancey moved this from New issues to In progress in Ads Apr 2, 2020
@tmancey
Copy link
Collaborator Author

@tmancey tmancey commented Apr 2, 2020

Fixed by #8932

@tmancey tmancey added the duplicate label Apr 2, 2020
@tmancey tmancey moved this from In progress to Done in Ads Apr 2, 2020
@tmancey tmancey removed the QA/Yes label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ads
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.