Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBrave Ad notifications are not shown on Windows until notifications are authorized #8843
Labels
Projects
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Brave Ad notifications are not shown on Windows until notifications are authorized
Steps to Reproduce
Actual result:
Ad notification is not shown on Windows until notifications are authorized, i.e. visiting http://bennish.net/web-notifications.html and clicking "Allow", i.e.
I could not reproduce the issue after uninstalling Brave Browser and installing version 1.5.115 (Chromium: 80.0.3987.149 (Official Build) (64-bit). The only difference I could see was that Brave appeared in "Notifications & actions" within Windows settings whereas before I uninstalled the older build this option was missing
Expected result:
Ad notification should be shown on Windows
Reproduces how often:
Intermittent issue
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
appeared in the debug logs caused by
src/chrome/browser/notifications/notification_platform_bridge_win.ccfailing withUnable to initialize toast notifier