Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monthly statement - AC values sum to amount greater than AC budget #8844

Open
LaurenWags opened this issue Mar 24, 2020 · 2 comments
Open

monthly statement - AC values sum to amount greater than AC budget #8844

LaurenWags opened this issue Mar 24, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Mar 24, 2020

Description

Probably due to rounding, but AC values on the monthly statement (in Auto-Contribute section) sometimes add up to greater than the actual AC amount.

Steps to Reproduce

  1. Have mix of verified and non-verified sites set up for AC
  2. Have AC to thru
  3. Look at monthly statement

Actual result:

0.1 + 0.1 + 0.3 + 4.3 + 0.5 = 5.3, but AC amount was only 5.0 BAT
Screen Shot 2020-03-24 at 3 31 14 PM

Expected result:

AC values add up to AC budget

Reproduces how often:

fairly easily, number of sites you have and your budget determines how far off you are though.

Brave version (brave://version info)

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @mandar-brave

@LaurenWags LaurenWags added this to New Issues in Rewards via automation Mar 24, 2020
@LaurenWags
Copy link
Collaborator Author

@LaurenWags LaurenWags commented Mar 24, 2020

Note, amount on Transactions section matches the amount in the Summary above, not what the sum from Auto Contribute section is:
Screen Shot 2020-03-24 at 3 40 05 PM

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Mar 25, 2020

@mandar-brave what should we do in this case? if we have one decimal place we will always have this rounding problems

@NejcZdovc NejcZdovc moved this from New Issues to Feature requests/Suggestion in Rewards Mar 25, 2020
@NejcZdovc NejcZdovc moved this from Feature requests/Suggestion to Need investigation/decision in Rewards Mar 25, 2020
@NejcZdovc NejcZdovc moved this from Need investigation to Decision in Rewards Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Decision (@mandar-brave)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.