Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "Google Translate" into context menu when right clicking website #8912

Open
kjozwiak opened this issue Mar 30, 2020 · 0 comments
Open

adding "Google Translate" into context menu when right clicking website #8912

kjozwiak opened this issue Mar 30, 2020 · 0 comments

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 30, 2020

Description

As per @BrendanEich, we should see if we can add the "Google Translate" extension capability to into the context menu so a user can TRANSLATE THIS PAGE by simply right clicking anywhere on the page rather than going through the extension icon.

The "Google Translate" icon does appear in the context menu in the following scenarios:

Right clicking on links*

Screen Shot 2020-03-29 at 11 53 14 PM

You'll also get a "Google Translate" button when selecting text as per the following:

Screen Shot 2020-03-29 at 11 53 02 PM

Steps to Reproduce

  1. visit https://www.spiegel.de and right click the page

Actual result:

Screen Shot 2020-03-30 at 12 05 03 AM

Expected result:

We should see if it's possible to add the "Google Translate" into the context menu when right clicking on pages so users can translate the page quicker without needing to click on the extension.

Reproduces how often:

100% reproducible when going through the above STR.

Brave version (brave://version info)

Brave | 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)
Brave | 1.7.76 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @BrendanEich

@rebron rebron added this to Untriaged Backlog in General Mar 31, 2020
@rebron rebron removed this from Untriaged Backlog in General Mar 31, 2020
@rebron rebron added this to P4 backlog in Front End Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.