Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making "Don't ask me again" look more like a button under translation popup #8922

Open
kjozwiak opened this issue Mar 30, 2020 · 0 comments
Open

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 30, 2020

Description

As suggested by @johnnyryan, we should make the Don't ask me again string via the Translation modal appear as an actual button so users know they can click and disable the popup that appears every time Brave detects another language the the Google Translate extension isn't installed.

Steps to Reproduce

  1. download and install brave
  2. visit a page in another language/locale (example: https://www.spiegel.de)

Actual result:

Screen Shot 2020-03-30 at 4 50 19 PM

Expected result:

Make the Don't ask me again appear as a button that's clickable rather than a string.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @johnnyryan @bsclifton

@rebron rebron added this to Untriaged Backlog in General Mar 31, 2020
@rebron rebron removed this from Untriaged Backlog in General Mar 31, 2020
@rebron rebron added this to Untriaged backlog in Front End Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
Untriaged backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.